fix(core): custom lsp configuration by ematipico · Pull Request #9049 · biomejs/biome

ematipico · 2026-02-13T10:38:55Z

Summary

Closes #7138

There were two bugs:

The way we loaded the configuration from the text_document event. Literally, we weren't checking for configuration_path.
The second, we were bailing in case we couldn't find an ignore file, missing the chance to save the root settings inside the Projects hashmap

Test Plan

Heavy manual testing using the user's reproduction

Docs

N/A bug fix

changeset-bot · 2026-02-13T10:39:02Z

🦋 Changeset detected

Latest commit: cdc1abf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/wasm-web	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-02-13T10:42:41Z

Walkthrough

The pull request fixes an issue where the Biome language server fails to honour the configurationPath setting from the VS Code extension. It introduces a precedence mechanism to prioritise user-provided configuration paths (via extension settings) before reverting to the original path-based resolution logic. Changes include a changelog entry, a new helper method in the session, conditional loading logic in the text document handler, and adjustments to workspace server configuration handling.

Possibly related PRs

fix(lsp): internal project handling #7377 — Modifies the same LSP configuration loading code paths in session and text document handlers.
fix(lsp): project loading #7418 — Introduces the ConfigurationPathHint::FromUser variant and related configuration load-flow changes.
fix(lsp): load extension settings before configuration on document open #7764 — Adjusts LSP document-open and extension settings handling to ensure configuration paths are respected.

Suggested labels

A-LSP, A-Project

Suggested reviewers

dyc3

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'fix(core): custom lsp configuration' accurately summarises the main change—fixing LSP configuration loading to respect custom configuration paths.
Description check	✅ Passed	The description clearly explains the two bugs fixed and links to issue `#7138`, relating directly to the changeset.
Linked Issues check	✅ Passed	The PR addresses both objectives from issue `#7138`: checking configuration_path during text_document event handling and preventing early exit when ignore files are missing.
Out of Scope Changes check	✅ Passed	All changes directly address the configuration loading bugs; the debug log formatting change in workspace.rs is a minor formatting improvement within scope.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into `main`

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/custom-configuration-loading

No actionable comments were generated in the recent review. 🎉

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

g-ortuno · 2026-03-07T23:18:30Z

crates/biome_lsp/src/session.rs

            ConfigurationPathHint::FromLsp(path) | ConfigurationPathHint::FromWorkspace(path) => {
                path.to_path_buf()
            }
+            ConfigurationPathHint::FromUser(path) => {


I'm running into a similar issue as #9217, except with absolute paths. With some AI help and some local logs I narrowed the issue to this line. I basically have a biome.jsonc file in something like c:/code/configs/biome.jsonc and projects in c:/code/foo_project.

Before this PR, setting configurationPath in VSCode would fall back to the _ case below, which would use base_path() as path which is later used to open the project. IIUC, base_path would be the workspace's path.

After this PR, this branch runs which uses the parent of the configuration file which in my case is c:/code/configs/.

I added a log after this function and I see the following, which confirms the above.

[CUSTOM-BUILD] Registering project at path: "c:/code/configs"

I also added a log to text_document.rs in did_open() in session.project_for_path(). So when I try to format a file I see the following in the logs:

[CUSTOM-BUILD] Could not find project for c:/code/foo_project/bad_formatted.ts

I have a mostly AI written PR at b27112a but I need to clean it up. Feel free to take over it though!

fix(core): custom lsp configuration

cdc1abf

ematipico requested review from a team February 13, 2026 10:39

github-actions bot added A-Project Area: project A-LSP Area: language server protocol labels Feb 13, 2026

ematipico merged commit c0ab6dd into main Feb 14, 2026
14 checks passed

ematipico deleted the fix/custom-configuration-loading branch February 14, 2026 14:47

github-actions bot mentioned this pull request Feb 13, 2026

ci: release #9045

Merged

coderabbitai bot mentioned this pull request Mar 4, 2026

fix(lsp): correctly resolve configurationPath #9323

Merged

g-ortuno reviewed Mar 7, 2026

View reviewed changes

This was referenced Mar 8, 2026

fix(lsp): fix incorrect project dir when configurationPath points to config outside of workspace #9392

Merged

fix(lsp): prefer most specific project root #9441

Merged

coderabbitai bot mentioned this pull request Mar 15, 2026

fix(diagnostic): include config path and CWD in ConfigurationOutsideProject #9488

Merged

coderabbitai bot mentioned this pull request Mar 23, 2026

fix(lsp): handle wrapped settings in didChangeConfiguration #9611

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(core): custom lsp configuration#9049

fix(core): custom lsp configuration#9049
ematipico merged 1 commit intomainfrom
fix/custom-configuration-loading

ematipico commented Feb 13, 2026 •

edited

Loading

Uh oh!

changeset-bot bot commented Feb 13, 2026

Uh oh!

coderabbitai bot commented Feb 13, 2026

Uh oh!

Uh oh!

g-ortuno Mar 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

ematipico commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Docs

Uh oh!

changeset-bot bot commented Feb 13, 2026

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Feb 13, 2026

Walkthrough

Possibly related PRs

Suggested labels

Suggested reviewers

Uh oh!

Uh oh!

g-ortuno Mar 7, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ematipico commented Feb 13, 2026 •

edited

Loading